linux-kernel - Re: [PATCH] audio: tlv320aic26: fix PLL register configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BANLkTikdKHi1Zr8Ae7ko7hkazR5yhHznTQ@mail.gmail.com>
Date:	Thu, 28 Apr 2011 18:17:45 -0400
From:	Mike Williamson <michael.williamson@...ticallink.com>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
	lrg@...mlogic.co.uk, tiwai@...e.de
Subject: Re: [PATCH] audio: tlv320aic26: fix PLL register configuration

On Thu, Apr 28, 2011 at 5:56 PM, Mark Brown
<broonie@...nsource.wolfsonmicro.com> wrote:
> On Thu, Apr 28, 2011 at 05:32:57PM -0400, Michael Williamson wrote:
>
>> -     jval = (fsref == 44100) ? 7 : 8;
>> -     dval = (fsref == 44100) ? 5264 : 1920;
>> +     jval = fsref / (aic26->mclk / 2048);
>> +     dval = fsref - jval * (aic26->mclk / 2048);
>
> I'd like some more brackets on this line, especially given the
> similarity with the previous line.  Otherwise this looks fine if a bit
> magic:

I will add some parens (and comment the magic?) and resubmit with your ack.

Thanks.

>
> Acked-by: Mark Brown <broonie@...nsource.wolfsonmicro.com>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/