linux-kernel - Re: [PATCH V2] kbuild: don't warn about include/linux/version.h not including itself

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110429134718.GE1619@sepie.suse.cz>
Date:	Fri, 29 Apr 2011 15:47:18 +0200
From:	Michal Marek <mmarek@...e.cz>
To:	Peter Foley <pefoley2@...izon.net>
Cc:	linux-kernel@...r.kernel.org, linux-kbuild@...r.kernel.org
Subject: Re: [PATCH V2] kbuild: don't warn about include/linux/version.h not
 including itself

On Tue, Apr 26, 2011 at 07:07:56PM -0400, Peter Foley wrote:
> This patch makes checkversion.pl not warn that include/linux/version.h
> dosen't include itself.
> 
> Signed-off-by: Peter Foley <pefoley2@...izon.net>
> ---
>  scripts/checkversion.pl |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/scripts/checkversion.pl b/scripts/checkversion.pl
> index b444e89..cf4b1dc 100755
> --- a/scripts/checkversion.pl
> +++ b/scripts/checkversion.pl
> @@ -12,6 +12,8 @@ $| = 1;
>  my $debugging;
>  
>  foreach my $file (@ARGV) {
> +    if($file !~ "include/linux/version\.h")
> +    {
>      # Open this file.

Enclosing the block in another pair of {...} is ugly, I changed it to


diff --git a/scripts/checkversion.pl b/scripts/checkversion.pl
index b444e89..5e490a8 100755
--- a/scripts/checkversion.pl
+++ b/scripts/checkversion.pl
@@ -12,6 +12,7 @@ $| = 1;
 my $debugging;
 
 foreach my $file (@ARGV) {
+    next if $file =~ "include/linux/version\.h";
     # Open this file.
     open( my $f, '<', $file )
       or die "Can't open $file: $!\n";

and pushed to kbuild-2.6.git#misc.

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/