[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4DBACC5C.1020502@gmail.com>
Date: Fri, 29 Apr 2011 08:34:04 -0600
From: David Ahern <dsahern@...il.com>
To: mingo@...hat.com, hpa@...or.com, acme@...hat.com,
linux-kernel@...r.kernel.org, fweisbec@...il.com,
a.p.zijlstra@...llo.nl, dsahern@...il.com, tglx@...utronix.de,
mingo@...e.hu
CC: linux-tip-commits@...r.kernel.org
Subject: Re: [tip:perf/stat] perf stat: Fail softly on unsupported events
On 04/29/11 08:27, tip-bot for Ingo Molnar wrote:
> Commit-ID: 370faf1dd0461ad811852c8abbbcd3d73b1e4fc4
> Gitweb: http://git.kernel.org/tip/370faf1dd0461ad811852c8abbbcd3d73b1e4fc4
> Author: Ingo Molnar <mingo@...e.hu>
> AuthorDate: Fri, 29 Apr 2011 16:11:03 +0200
> Committer: Ingo Molnar <mingo@...e.hu>
> CommitDate: Fri, 29 Apr 2011 16:22:33 +0200
>
> perf stat: Fail softly on unsupported events
>
> David Ahern reported this perf stat failure:
>
>> # /tmp/build-perf/perf stat -- sleep 1
>> Error: stalled-cycles-frontend event is not supported.
>> Fatal: Not all events could be opened.
>>
>> This is a Dell R410 with an E5620 processor.
>
> Fail in a softer fashion on unknown/unsupported events.
>
> Reported-by: David Ahern <dsahern@...il.com>
> Cc: Peter Zijlstra <a.p.zijlstra@...llo.nl>
> Cc: Arnaldo Carvalho de Melo <acme@...hat.com>
> Cc: Frederic Weisbecker <fweisbec@...il.com>
> Link: http://lkml.kernel.org/n/tip-7y40wib8n006io7hjpn1dsrm@git.kernel.org
> Signed-off-by: Ingo Molnar <mingo@...e.hu>
> ---
> tools/perf/builtin-stat.c | 4 +---
> 1 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
> index 9e596ab..c8b535b 100644
> --- a/tools/perf/builtin-stat.c
> +++ b/tools/perf/builtin-stat.c
> @@ -377,7 +377,7 @@ static int run_perf_stat(int argc __used, const char **argv)
>
> list_for_each_entry(counter, &evsel_list->entries, node) {
> if (create_perf_stat_counter(counter) < 0) {
> - if (errno == EINVAL || errno == ENOSYS)
> + if (errno == EINVAL || errno == ENOSYS || errno == ENOENT)
> continue;
>
> if (errno == EPERM || errno == EACCES) {
> @@ -385,8 +385,6 @@ static int run_perf_stat(int argc __used, const char **argv)
> "\t Consider tweaking"
> " /proc/sys/kernel/perf_event_paranoid or running as root.",
> system_wide ? "system-wide " : "");
> - } else if (errno == ENOENT) {
> - error("%s event is not supported. ", event_name(counter));
This silently ignores events -- including ones that a user requested. I
think a better option is a continue here.
/tmp/build-perf/perf stat -- sleep 1
Error: stalled-cycles-frontend event is not supported.
Error: stalled-cycles-backend event is not supported.
> } else {
> error("open_counter returned with %d (%s). "
> "/bin/dmesg may provide additional information.\n",
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists