linux-kernel - Re: [PATCH V4] tty/serial: add support for Xilinx PS UART

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1369027353.2095897.1304114559625.JavaMail.root@sz0140a.emeryville.ca.mail.comcast.net>
Date:	Fri, 29 Apr 2011 22:02:39 +0000 (UTC)
From:	johnlinn@...cast.net
To:	Greg KH <greg@...ah.com>
Cc:	linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org,
	alan@...rguk.ukuu.org.uk,
	michal simek <michal.simek@...alogix.com>, joe@...ches.com,
	grant likely <grant.likely@...retlab.ca>,
	John Linn <john.linn@...inx.com>
Subject: Re: [PATCH V4] tty/serial: add support for Xilinx PS UART


> On Wed, Apr 27, 2011 at 12:17:36PM -0600, johnlinn@...cast.net wrote:
> > From: John Linn <john.linn@...inx.com>
> > 
> > The Xilinx PS Uart is used on the new ARM based SoC. This
> > UART is not compatible with others such that a seperate
> > driver is required.
> > 
> > Signed-off-by: John Linn <john.linn@...inx.com>
> 
> I get build failures with this patch:
> 
>   CC [M]  drivers/tty/serial/xilinx_uartps.o
> drivers/tty/serial/xilinx_uartps.c: In function ‘xuartps_get_port’:
> drivers/tty/serial/xilinx_uartps.c:785:14: error: ‘NO_IRQ’ undeclared
> (first use in this function)
> drivers/tty/serial/xilinx_uartps.c:785:14: note: each undeclared
> identifier is reported only once for each function it appears in
> make[1]: *** [drivers/tty/serial/xilinx_uartps.o] Error 1
> 
> Care to fix this up so it's in a state I can properly apply it to the
> tree?
> 
> thanks,
> 
> greg k-h

Done and sent out as V5 of patch.

Just for future reference (and maybe I should know this).  How should I 
have prevented this problem? I guess I would need to build the kernel 
for other architectures and I don't normally do that.

Thanks,
John
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/