linux-kernel - Re: [PATCH 2/2] x86: Change trap definitions to enumerated values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.02.1104290233490.3005@ionos>
Date:	Fri, 29 Apr 2011 02:38:55 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Vaibhav Nagarnaik <vnagarnaik@...gle.com>
cc:	Steven Rostedt <rostedt@...dmis.org>,
	Ingo Molnar <mingo@...hat.com>,
	Michael Rubin <mrubin@...gle.com>,
	David Sharp <dhsharp@...gle.com>, linux-kernel@...r.kernel.org,
	x86@...nel.org, Aditya Kali <adityakali@...gle.com>
Subject: Re: [PATCH 2/2] x86: Change trap definitions to enumerated values

On Fri, 22 Apr 2011, Vaibhav Nagarnaik wrote:

> From: Aditya Kali <adityakali@...gle.com>
> 
> The traps are referred to by their numbers and it can be difficult to
> understand them while reading the code without context. This patch adds
> enumeration of the trap numbers and replaced the numbers to the correct
> enum for x86.

I really like that patch, but it should have been 1/2 as it has a
value independent of the trap trace stuff.

And if you had done that, then the trap trace patch could have used
those symbols instead of the numbers as well.

Now that's the 2/2 patch and leaves the (not so) shiny new trace
points with those weird numbers. :(

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/