linux-kernel - Re: [PATCH V3 2/7] dmaengine/dw_dmac: Replace spin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 29 Apr 2011 15:48:42 +0530
From:	viresh kumar <viresh.kumar@...com>
To:	Russell King - ARM Linux <linux@....linux.org.uk>
Cc:	"vinod.koul@...el.com" <vinod.koul@...el.com>,
	"dan.j.williams@...el.com" <dan.j.williams@...el.com>,
	Armando VISCONTI <armando.visconti@...com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Shiraz HASHIM <shiraz.hashim@...com>,
	"viresh.linux@...il.com" <viresh.linux@...il.com>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH V3 2/7] dmaengine/dw_dmac: Replace spin_lock* with	irqsave
 variants

On 04/28/2011 10:40 PM, Russell King - ARM Linux wrote:
> On Wed, Apr 27, 2011 at 03:06:44PM +0530, Viresh Kumar wrote:
>> @@ -407,6 +410,8 @@ EXPORT_SYMBOL(dw_dma_get_dst_addr);
>>  static void dwc_handle_cyclic(struct dw_dma *dw, struct dw_dma_chan *dwc,
>>  		u32 status_block, u32 status_err, u32 status_xfer)
>>  {
>> +	unsigned long flags;
>> +
>>  	if (status_block & dwc->mask) {
>>  		void (*callback)(void *param);
>>  		void *callback_param;
>> @@ -418,9 +423,9 @@ static void dwc_handle_cyclic(struct dw_dma *dw, struct dw_dma_chan *dwc,
>>  		callback = dwc->cdesc->period_callback;
>>  		callback_param = dwc->cdesc->period_callback_param;
>>  		if (callback) {
>> -			spin_unlock(&dwc->lock);
>> +			spin_unlock_irqrestore(&dwc->lock, flags);
>>  			callback(callback_param);
>> -			spin_lock(&dwc->lock);
>> +			spin_lock_irqsave(&dwc->lock, flags);
> 
> I'm really not convinced that this is anywhere near correct.  I'm
> surprised this doesn't spit out a compiler warning.
> 

Sorry, this is done by mistake.

-- 
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/