linux-kernel - Re: [PATCH 03/25] x86-64, NUMA: simplify nodedata allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110430120217.GD29280@htj.dyndns.org>
Date:	Sat, 30 Apr 2011 14:02:17 +0200
From:	Tejun Heo <tj@...nel.org>
To:	Yinghai Lu <yinghai@...nel.org>
Cc:	mingo@...hat.com, rientjes@...gle.com, tglx@...utronix.de,
	hpa@...or.com, x86@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 03/25] x86-64, NUMA: simplify nodedata allocation

On Fri, Apr 29, 2011 at 10:23:27AM -0700, Yinghai Lu wrote:
> On 04/29/2011 08:28 AM, Tejun Heo wrote:
> > With top-down memblock allocation, the allocation range limits in
> > ealry_node_mem() can be simplified - try node-local first, then any
> > node but in any case don't allocate below DMA limit.
> > 
> > Remove early_node_mem() and implement simplified allocation directly
> > in setup_node_bootmem().
> 
> keep early_node_mem would be better?

I don't know, maybe, maybe not.  I usually find separating out linear
procedural logic into a function, which is used only once, more
distracting / obfuscating than helpful.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/