[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20110429234028.GA28476@kroah.com>
Date: Fri, 29 Apr 2011 16:40:28 -0700
From: Greg KH <greg@...ah.com>
To: Mike Waychison <mikew@...gle.com>
Cc: Matt Domsch <Matt_Domsch@...l.com>,
Alan Cox <alan@...rguk.ukuu.org.uk>,
Duncan Laurie <dlaurie@...gle.com>,
Aaron Durbin <adurbin@...gle.com>, x86@...nel.org,
linux-kernel@...r.kernel.org, Tim Hockin <thockin@...gle.com>,
San Mehat <san@...gle.com>
Subject: Re: [PATCH v4 1/3] driver: Google EFI SMI
On Fri, Apr 29, 2011 at 03:55:51PM -0700, Mike Waychison wrote:
> The "gsmi" driver bridges userland with firmware specific routines for
> accessing hardware.
>
> Currently, this driver only supports NVRAM and eventlog information.
> Deprecated functions have been removed from the driver, though their
> op-codes are left in place so that they are not re-used.
>
> This driver works by trampolining into the firmware via the smi_command
> outlined in the FADT table. Three protocols are used due to various
> limitations over time, but all are included herein.
>
> This driver should only ever load on Google boards, identified by either
> a "Google, Inc." board vendor string in DMI, or "GOOGLE" in the OEM
> strings of the FADT ACPI table. This logic happens in
> gsmi_system_valid().
>
> Signed-off-by: Duncan Laurie <dlaurie@...gle.com>
> Signed-off-by: Aaron Durbin <adurbin@...gle.com>
> Signed-off-by: Mike Waychison <mikew@...gle.com>
{sigh}
I now get this build error with this patch applied:
CC [M] drivers/firmware/google/gsmi.o
drivers/firmware/google/gsmi.c: In function ‘gsmi_die_callback’:
drivers/firmware/google/gsmi.c:660:16: error: ‘DIE_NMIWATCHDOG’ undeclared (first use in this function)
drivers/firmware/google/gsmi.c:660:16: note: each undeclared identifier is reported only once for each function it appears in
make[3]: *** [drivers/firmware/google/gsmi.o] Error 1
Also, I had to hand edit the drivers/firmware/Makefile and Kconfig parts
of this patch to get it to apply, care to respin it against the
linux-next tree so I don't have to do that next time around?
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists