linux-kernel - Re: [PATCH tip:x86/urgent] x86, NUMA: Fix empty memblk detection in numa_cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110501165354.GC21833@elte.hu>
Date:	Sun, 1 May 2011 18:53:54 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Tejun Heo <tj@...nel.org>
Cc:	Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org,
	x86@...nel.org, Yinghai Lu <yinghai@...nel.org>
Subject: Re: [PATCH tip:x86/urgent] x86, NUMA: Fix empty memblk detection in
 numa_cleanup_meminfo()


* Tejun Heo <tj@...nel.org> wrote:

> From: Yinghai Lu <yinghai@...nel.org>
> 
> numa_cleanup_meminfo() trims each memblk between low (0) and high
> (max_pfn) limits and discards empty ones.  However, the emptiness
> detection incorrectly used equality test.  If the start of a memblk is
> higher than max_pfn, it is empty but fails the equality test and
> doesn't get discarded.
> 
> Fix it by using >= instead of ==.
> 
> tj: Extracted the actual fix from the original patch and rewrote patch
>     description.

Well, the bit still missing from the description is why this fix matters for 
x86/urgent: under what scenarios does this cause problems, how frequent is it, 
how severe are the prolems, etc. etc. Would be nice to have something about 
that in the changelog as well.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/