linux-kernel - Re: [PATCH 1/2] Check PageUnevictable in lru_deactivate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BANLkTim1k-wGA1j9Cv1scCNR_-5b9BqESQ@mail.gmail.com>
Date:	Mon, 2 May 2011 08:00:46 +0900
From:	Minchan Kim <minchan.kim@...il.com>
To:	Ying Han <yinghan@...gle.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-mm <linux-mm@...ck.org>,
	LKML <linux-kernel@...r.kernel.org>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	Johannes Weiner <hannes@...xchg.org>,
	Rik van Riel <riel@...hat.com>,
	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
	Mel Gorman <mgorman@...e.de>
Subject: Re: [PATCH 1/2] Check PageUnevictable in lru_deactivate_fn

On Mon, May 2, 2011 at 7:10 AM, Ying Han <yinghan@...gle.com> wrote:
> On Sun, May 1, 2011 at 8:03 AM, Minchan Kim <minchan.kim@...il.com> wrote:
>> The lru_deactivate_fn should not move page which in on unevictable lru
>> into inactive list. Otherwise, we can meet BUG when we use isolate_lru_pages
>> as __isolate_lru_page could return -EINVAL.
>> It's really BUG and let's fix it.
>>
>> Reported-by: Ying Han <yinghan@...gle.com>
>> Tested-by: Ying Han <yinghan@...gle.com>
>> Signed-off-by: Minchan Kim <minchan.kim@...il.com>
>> ---
>>  mm/swap.c |    3 +++
>>  1 files changed, 3 insertions(+), 0 deletions(-)
>>
>> diff --git a/mm/swap.c b/mm/swap.c
>> index a83ec5a..2e9656d 100644
>> --- a/mm/swap.c
>> +++ b/mm/swap.c
>> @@ -429,6 +429,9 @@ static void lru_deactivate_fn(struct page *page, void *arg)
>>        if (!PageLRU(page))
>>                return;
>>
>> +       if (PageUnevictable(page))
>> +               return;
>> +
>>        /* Some processes are using the page */
>>        if (page_mapped(page))
>>                return;
>> --
>> 1.7.1
>
> Thanks Minchan for the fix, and i haven't been able to reproducing the
> issue after applying the patch.

Thanks for the help, Ying.

-- 
Kind regards,
Minchan Kim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/