linux-kernel - Re: [patch 1/2] x86, x2apic: minimize IPI register writes using cluster groups v4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4DBECAB4.7020809@gmail.com>
Date:	Mon, 02 May 2011 19:16:04 +0400
From:	Cyrill Gorcunov <gorcunov@...il.com>
To:	Ingo Molnar <mingo@...e.hu>
CC:	Suresh Siddha <suresh.b.siddha@...el.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [patch 1/2] x86, x2apic: minimize IPI register writes using cluster
 groups v4

On 05/02/2011 07:05 PM, Ingo Molnar wrote:
...
>>
>>   Ingo, would it be fine to make apic->init() either _before_ this series or 
>> on top of them (because if I introduce it inside this particular patch it 
>> would contain some unrelated code snippets such as .init = NULL for all apics 
>> declaration).
> 
> Of course it should be a separate patch - even this patch looks a bit large - 
> any way to split it up further?

  Well, for this particular path the only minimum is used, so i fear there is no
way to split it, probably I could drop some 'cleanup' bits from it and make it
a separate one. Gimme some time.

> 
> And yes, if it fits it should be in apic->probe() instead of introducing a new 
> ->init() method.

  I'll recheck. Thanks for all comments Ingo, drop this series for a while then.

> 
> Thanks,
> 
> 	Ingo


-- 
Thanks,
  Cyrill
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/