linux-kernel - Re: [PATCH 3/3] blkdev: honor discard_granularity in blkdev_issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yq1pqo12fqo.fsf@sermon.lab.mkp.net>
Date:	Mon, 02 May 2011 13:07:27 -0400
From:	"Martin K. Petersen" <martin.petersen@...cle.com>
To:	Jeff Moyer <jmoyer@...hat.com>
Cc:	"Martin K. Petersen" <martin.petersen@...cle.com>,
	Lukas Czerner <lczerner@...hat.com>,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	Dmitry Monakhov <dmonakhov@...nvz.org>,
	Jens Axboe <jaxboe@...ionio.com>
Subject: Re: [PATCH 3/3] blkdev: honor discard_granularity in blkdev_issue_discard()

>>>>> "Jeff" == Jeff Moyer <jmoyer@...hat.com> writes:

Jeff> Hm, I wonder where it makes sense to document this.  Maybe
Jeff> Documentation/block/queue-sysfs.txt, but I admit I wouldn't have
Jeff> looked there while reviewing this code.

Maybe we could simply add a comment in the kerneldoc header for
blkdev_issue_discard()?

I tried to keep Documentation/ABI/ up to date for the topology stuff but
it looks like the discard portions never got merged. Probably fell
through the cracks. I'll dig up the patch.

But as you say -- I'm sure nobody looks. My only motivation for keeping
the sysfs ABI doc in sync is to avoid gregkh's wrath...

-- 
Martin K. Petersen	Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/