linux-kernel - Re: [PATCH] Fix the over time interface of the driver-model docs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110502032906.GA1553@kroah.com>
Date:	Sun, 1 May 2011 20:29:06 -0700
From:	Greg KH <greg@...ah.com>
To:	Randy Dunlap <rdunlap@...otime.net>, wanlong.gao@...il.com,
	linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Fix the over time interface of the driver-model docs

On Sun, May 01, 2011 at 07:59:39PM -0700, Randy Dunlap wrote:
> On Sun,  1 May 2011 13:50:56 +0800 wanlong.gao@...il.com wrote:
> 
> > From: Wanlong Gao<wanlong.gao@...il.com>
> > 
> > The driver-model documentation seems like out-of-date, Can we
> > fix them or rewrite ?
> 
> GregKH should get this patch.......
> 
> 
> > Signed-off-by: Wanlong Gao<wanlong.gao@...il.com>
> > ---
> >  Documentation/driver-model/bus.txt    |   32 ++++----
> >  Documentation/driver-model/device.txt |  149 +++++++++++++++++++--------------
> >  2 files changed, 104 insertions(+), 77 deletions(-)
> > 
> > diff --git a/Documentation/driver-model/bus.txt b/Documentation/driver-model/bus.txt
> > index 5001b75..82bca26 100644
> > --- a/Documentation/driver-model/bus.txt
> > +++ b/Documentation/driver-model/bus.txt
> > @@ -5,21 +5,23 @@ Definition
> >  ~~~~~~~~~~
> >  
> >  struct bus_type {
> > -	char			* name;
> > +	const char		*name;
> > +	struct bus_attribute	*bus_attrs;
> > +	struct device_attribute	*dev_attrs;
> > +	struct driver_attribute	*drv_attrs;


<snip>

This should almost all removed from these files and moved to be
kerneldoc in the device.h file instead.  That will keep things up to
date and provide a better way to document this stuff.

Wanlong, can you do that instead?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/