linux-kernel - Re: [PATCH tip/core/rcu 10/86] rcu: eliminate unused boosting statistics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110502082555.GV2297@linux.vnet.ibm.com>
Date:	Mon, 2 May 2011 01:25:56 -0700
From:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To:	Josh Triplett <josh@...htriplett.org>
Cc:	linux-kernel@...r.kernel.org, mingo@...e.hu, laijs@...fujitsu.com,
	dipankar@...ibm.com, akpm@...ux-foundation.org,
	mathieu.desnoyers@...ymtl.ca, niv@...ibm.com, tglx@...utronix.de,
	peterz@...radead.org, rostedt@...dmis.org, Valdis.Kletnieks@...edu,
	dhowells@...hat.com, eric.dumazet@...il.com, darren@...art.com,
	patches@...aro.org, "Paul E. McKenney" <paul.mckenney@...aro.org>
Subject: Re: [PATCH tip/core/rcu 10/86] rcu: eliminate unused boosting
 statistics

On Sun, May 01, 2011 at 08:53:18AM -0700, Josh Triplett wrote:
> On Sun, May 01, 2011 at 06:20:50AM -0700, Paul E. McKenney wrote:
> > From: Paul E. McKenney <paul.mckenney@...aro.org>
> > 
> > The n_rcu_torture_boost_allocerror and n_rcu_torture_boost_afferror
> > statistics are not actually incremented anymore, so eliminate them.
> > 
> > Signed-off-by: Paul E. McKenney <paul.mckenney@...aro.org>
> > Signed-off-by: Paul E. McKenney <paulmck@...ux.vnet.ibm.com>
> > ---
> >  kernel/rcutorture.c |    4 +---
> >  1 files changed, 1 insertions(+), 3 deletions(-)
> > 
> > diff --git a/kernel/rcutorture.c b/kernel/rcutorture.c
> > index 4d256db..62ec8ee6 100644
> > --- a/kernel/rcutorture.c
> > +++ b/kernel/rcutorture.c
> > @@ -1067,7 +1067,7 @@ rcu_torture_printk(char *page)
> >  	cnt += sprintf(&page[cnt], "%s%s ", torture_type, TORTURE_FLAG);
> >  	cnt += sprintf(&page[cnt],
> >  		       "rtc: %p ver: %ld tfle: %d rta: %d rtaf: %d rtf: %d "
> > -		       "rtmbe: %d rtbke: %ld rtbre: %ld rtbae: %ld rtbafe: %ld "
> > +		       "rtmbe: %d rtbke: %ld rtbre: %ld "
> >  		       "rtbf: %ld rtb: %ld nt: %ld",
> >  		       rcu_torture_current,
> >  		       rcu_torture_current_version,
> > @@ -1078,8 +1078,6 @@ rcu_torture_printk(char *page)
> >  		       atomic_read(&n_rcu_torture_mberror),
> >  		       n_rcu_torture_boost_ktrerror,
> >  		       n_rcu_torture_boost_rterror,
> > -		       n_rcu_torture_boost_allocerror,
> > -		       n_rcu_torture_boost_afferror,
> >  		       n_rcu_torture_boost_failure,
> >  		       n_rcu_torture_boosts,
> >  		       n_rcu_torture_timers);
> 
> Shouldn't you eliminate the variables entirely, if they no longer track
> anything?

I most certainly should!!!  Good catch!!!

							Thanx, Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/