linux-kernel - Re: [PATCH] usbvision: remove (broken) image format conversion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 03 May 2011 07:29:45 -0300
From:	Mauro Carvalho Chehab <mchehab@...hat.com>
To:	Ondrej Zary <linux@...nbow-software.org>
CC:	Hans Verkuil <hverkuil@...all.nl>,
	Hans de Goede <hdegoede@...hat.com>,
	Joerg Heckenbach <joerg@...kenbach-aw.de>,
	Dwaine Garden <dwainegarden@...ers.com>,
	linux-media@...r.kernel.org,
	Kernel development list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] usbvision: remove (broken) image format conversion

Em 26-04-2011 17:40, Ondrej Zary escreveu:
> On Tuesday 26 April 2011 14:33:20 Hans Verkuil wrote:

> After digging in the code for hours, I'm giving this up. It's not worth it.
> 
> The ISOC_MODE_YUV422 mode works as V4L2_PIX_FMT_YVYU with VLC and 
> mplayer+libv4lconvert, reducing the loop (and dropping strech_*) in 
> usbvision_parse_lines_422() to:
>  scratch_get(usbvision, frame->data + (frame->v4l2_linesize * frame->curline),
>  2 * frame->frmwidth);
> 
> The ISOC_MODE_YUV420 is some weird custom format with 64-byte lines of YYUV. 
> usbvision_parse_lines_420() is real mess with that scratch_* crap everywhere.
> 
> ISOC_MODE_COMPRESS: There are callbacks to usbvision_request_intra() and also 
> usbvision_adjust_compression(). This is not going to work outside the kernel.
> 
> 
> So I can redo the conversion removal patch to keep the RGB formats and also 
> provide another one to remove the testpattern (it oopses too). But I'm not 
> going to do any major changes in the driver.

While in a perfect world, this should be moved to userspace, I'm ok on keeping
it there, but the OOPS/Panic conditions should be fixed.

Could you please work on a patch fixing the broken stuff, without removing the
conversions?

Thanks,
Mauro
 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/