linux-kernel - Re: [RFC 1/5] platform-drivers-x86: add support for Technologic Systems TS-5xxx detection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110503141345.GB8056@kroah.com>
Date:	Tue, 3 May 2011 07:13:45 -0700
From:	Greg KH <greg@...ah.com>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	Vivien Didelot <vivien.didelot@...oirfairelinux.com>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Jonas Fonseca <jonas.fonseca@...oirfairelinux.com>,
	platform-driver-x86 <platform-driver-x86@...r.kernel.org>,
	linux-serial <linux-serial@...r.kernel.org>,
	lm-sensors <lm-sensors@...sensors.org>
Subject: Re: [RFC 1/5] platform-drivers-x86: add support for Technologic
 Systems TS-5xxx detection

On Tue, May 03, 2011 at 10:39:19AM +0100, Alan Cox wrote:
> > > I had a look at other drivers, and /sys/devices/platform/ts/ seems to be
> > > a good place to hold those entries (one per options as you suggested).
> > > Do you agree with that?
> > 
> > No, this is not a platform device, is it?  Only platform devices go
> > there, and I really doubt you have many of them for this board.
> 
> It seems analogous to some of the laptop helpers so I don't think it is
> that unreasonable to make the board config a platform device of its own -
> we don't really have a general solution to the board as a device, so if
> you look at equivalents on laptops and the like we have assorted platform
> control interfaces that are platform devices.

Platform control devices are great, I have no objection to that.  I do
object to random proc files to try to describe the fact that this board
has a rs232 port on it, when that is able to be determined elsewhere.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/