linux-kernel - Re: [PATCH 3/4] x86, mce: Add persistent MCE event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1304435656.1788.8.camel@Joe-Laptop>
Date:	Tue, 03 May 2011 08:14:16 -0700
From:	Joe Perches <joe@...ches.com>
To:	Borislav Petkov <bp@...64.org>
Cc:	Ingo Molnar <mingo@...e.hu>, Peter Zijlstra <peterz@...radead.org>,
	Arnaldo Carvalho de Melo <acme@...radead.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Tony Luck <tony.luck@...el.com>,
	Mauro Carvalho Chehab <mchehab@...hat.com>,
	EDAC devel <linux-edac@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	"Petkov, Borislav" <Borislav.Petkov@....com>
Subject: Re: [PATCH 3/4] x86, mce: Add persistent MCE event

On Tue, 2011-05-03 at 09:18 +0200, Borislav Petkov wrote:
> On Tue, May 03, 2011 at 02:44:01AM -0400, Ingo Molnar wrote:
> > * Borislav Petkov <bp@...64.org> wrote:
[]
> > > +static struct dentry *mce_add_event_debugfs(struct perf_event *event, int cpu)
> > > +{
> > > +	char buf[14];
> > > +
> > > +	sprintf(buf, "mce_record%d", cpu);

trivia:

buf[14] doesn't fit 10k+ cpus.
Isn't that an unnecessary future/current problem?
Maybe something bigger?
	char buf[sizeof("mce_record") + sizeof(int) * 3] 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/