linux-kernel - Re: [PATCH 3/5] TPS65911: Add new irq definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110503173011.GE1762@opensource.wolfsonmicro.com>
Date:	Tue, 3 May 2011 18:30:12 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Jorge Eduardo Candelaria <jedu@...mlogic.co.uk>
Cc:	linux-kernel@...r.kernel.org, sameo@...ux.intel.com, lrg@...com,
	Graeme Gregory <gg@...mlogic.co.uk>, grant.likely@...retlab.ca
Subject: Re: [PATCH 3/5] TPS65911: Add new irq definitions

On Tue, May 03, 2011 at 11:18:56AM -0500, Jorge Eduardo Candelaria wrote:

> +	if (tps65910_chip_id(tps65910) == TPS65911) {
> +		tps65910->read(tps65910, TPS65910_INT_STS3, 1, &reg);
> +		irq_sts |= reg << 16;
> +	}

switch statements feel better for future proofing - if your hardware
guys do another design derived from this base you'll need to add another
case in here.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/