linux-kernel - Re: [PATCH 1/2] x86: Change trap definitions to enumerated values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BANLkTinqHNCzcZmQL6M-pCszTmPO=-X8yw@mail.gmail.com>
Date:	Tue, 3 May 2011 12:00:07 -0700
From:	Vaibhav Nagarnaik <vnagarnaik@...gle.com>
To:	Don Zickus <dzickus@...hat.com>
Cc:	Steven Rostedt <rostedt@...dmis.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	Michael Rubin <mrubin@...gle.com>,
	David Sharp <dhsharp@...gle.com>, linux-kernel@...r.kernel.org,
	x86@...nel.org, Aditya Kali <adityakali@...gle.com>
Subject: Re: [PATCH 1/2] x86: Change trap definitions to enumerated values

On Tue, May 3, 2011 at 6:18 AM, Don Zickus <dzickus@...hat.com> wrote:
> On Fri, Apr 29, 2011 at 05:52:52PM -0700, Vaibhav Nagarnaik wrote:
>> From: Aditya Kali <adityakali@...gle.com>
>>
>> The traps are referred to by their numbers and it can be difficult to
>> understand them while reading the code without context. This patch adds
>> enumeration of the trap numbers and replaced the numbers to the correct
>> enum for x86.
>
> My only problem with this patch is you took a straight forward conversion
> which didn't really change the functionality and sprinkled some trace
> points in there.

Actually, readability and maintainability was the goal to create the patch.
When the tracepoints are added, they can use the enum values rather than
floating magic numbers.

Thomas and Steven,
Would it make better sense to separate this patch into 2 patches, the first
one replacing the numbers to enums and the second one adding the tracepoints?


>
> I am ok with the conversion to something readable, but I don't know enough
> about the trace point to know if those are correct spots.
>
> Cheers,
> Don
>
>>
>> Signed-off-by: Vaibhav Nagarnaik <vnagarnaik@...gle.com>
>> ---


Thanks

Vaibhav Nagarnaik
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/