linux-kernel - Re: [PATCH 2/4] perf: Add persistent event facilities

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110503082234.GB6999@elte.hu>
Date:	Tue, 3 May 2011 10:22:34 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Borislav Petkov <bp@...64.org>
Cc:	Peter Zijlstra <peterz@...radead.org>,
	Arnaldo Carvalho de Melo <acme@...radead.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Tony Luck <tony.luck@...el.com>,
	Mauro Carvalho Chehab <mchehab@...hat.com>,
	EDAC devel <linux-edac@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/4] perf: Add persistent event facilities


* Borislav Petkov <bp@...64.org> wrote:

> > we could move the other perf_events.c facilities there as well, and maybe 
> > split up the file a bit, it's 7.5 KLOC now which is a bit excessive.
> 
> Right, so I left perf_event.c as a whole on purpose (only renamed) because it 
> makes more sense IMHO for someone who actually wrote it to split it in 
> logical parts (^hint hint^). I mean, I could do it too but it'll take me much 
> more time :).

Well you are now writing new events code as well so spending that time might be 
a good investment in terms of getting persistent.c right as well.

Could you send a Git pull request against perf/core that does the obvious file 
movement and renaming? We can do that first step straight away and get the ball 
rolling.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/