[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1304414973.27863.2.camel@e102144-lin.cambridge.arm.com>
Date: Tue, 03 May 2011 10:29:33 +0100
From: Will Deacon <will.deacon@....com>
To: Colin Cross <ccross@...roid.com>
Cc: lakml <linux-arm-kernel@...ts.infradead.org>,
linux-tegra <linux-tegra@...r.kernel.org>,
Marc Zyngier <Marc.Zyngier@....com>,
Erik Gilling <konkers@...roid.com>,
Olof Johansson <olof@...om.net>,
Russell King <linux@....linux.org.uk>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCHv2 4/4] ARM: tegra: irq: Add tegra_eoi
Hi Colin,
On Sun, 2011-05-01 at 23:27 +0100, Colin Cross wrote:
> Implement irq_eoi to allow the GIC irq chip flow controller to
> be changed to fasteoi.
>
> Signed-off-by: Colin Cross <ccross@...roid.com>
> ---
> v2: Add tegra_eoi without removing tegra_ack, patch can now be
> merged safely before Will Deacon's gic fasteoi patch
>
> arch/arm/mach-tegra/irq.c | 9 +++++++++
> 1 files changed, 9 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-tegra/irq.c b/arch/arm/mach-tegra/irq.c
> index da17491..4956c3c 100644
> --- a/arch/arm/mach-tegra/irq.c
> +++ b/arch/arm/mach-tegra/irq.c
> @@ -95,6 +95,14 @@ static void tegra_ack(struct irq_data *d)
> tegra_irq_write_mask(d->irq, ICTLR_CPU_IEP_FIR_CLR);
> }
>
> +static void tegra_eoi(struct irq_data *d)
> +{
> + if (d->irq < FIRST_LEGACY_IRQ)
> + return;
> +
> + tegra_irq_write_mask(d->irq, ICTLR_CPU_IEP_FIR_CLR);
> +}
> +
> static int tegra_retrigger(struct irq_data *d)
> {
> if (d->irq < FIRST_LEGACY_IRQ)
> @@ -116,6 +124,7 @@ void __init tegra_init_irq(void)
> }
>
> gic_arch_extn.irq_ack = tegra_ack;
> + gic_arch_extn.irq_eoi = tegra_eoi;
> gic_arch_extn.irq_mask = tegra_mask;
> gic_arch_extn.irq_unmask = tegra_unmask;
> gic_arch_extn.irq_retrigger = tegra_retrigger;
> --
> 1.7.4.1
Just the job!
Acked-by: Will Deacon <will.deacon@....com>
Thanks,
Will
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists