linux-kernel - Re: [PATCH] atomic: add *_dec_not

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BANLkTimctgbto3dsnJ3d3r7NggS0KF9_Sw@mail.gmail.com>
Date:	Wed, 4 May 2011 04:33:24 -0400
From:	Mike Frysinger <vapier.adi@...il.com>
To:	David Laight <David.Laight@...lab.com>
Cc:	Sven Eckelmann <sven@...fation.org>, linux-kernel@...r.kernel.org,
	linux-arch@...r.kernel.org, linux-mips@...ux-mips.org,
	linux-m32r@...linux-m32r.org, linux-ia64@...r.kernel.org,
	linux-parisc@...r.kernel.org, linux-cris-kernel@...s.com,
	linux-s390@...r.kernel.org, linux-sh@...r.kernel.org,
	x86@...nel.org, Chris Metcalf <cmetcalf@...era.com>,
	David Howells <dhowells@...hat.com>,
	linux-m68k@...ts.linux-m68k.org, linux-am33-list@...hat.com,
	linux-alpha@...r.kernel.org, sparclinux@...r.kernel.org,
	uclinux-dist-devel@...ckfin.uclinux.org,
	linuxppc-dev@...ts.ozlabs.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] atomic: add *_dec_not_zero

On Wed, May 4, 2011 at 04:05, David Laight wrote:
>> Introduce an *_dec_not_zero operation.  Make this a special case of
>> *_add_unless because batman-adv uses atomic_dec_not_zero in different
>> places like re-broadcast queue or aggregation queue management. There
>> are other non-final patches which may also want to use this macro.
>
> Isn't there a place where a default definition of this can be
> defined? Instead of adding it separately to every architecture.

that's what asm-generic is for.  if the arch isnt using it, it's
either because the arch needs to convert to it, or they're using SMP
and asm-generic doesnt yet support that for atomic.h.

for example, the Blackfin port only needed updating for the SMP case.
in the non-SMP case, we're getting the def from asm-generic/atomic.h.
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/