[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20110504152054.GA23210@elte.hu>
Date: Wed, 4 May 2011 17:20:54 +0200
From: Ingo Molnar <mingo@...e.hu>
To: Christoph Lameter <cl@...ux.com>
Cc: Tejun Heo <tj@...nel.org>, Thomas Gleixner <tglx@...utronix.de>,
Pekka Enberg <penberg@...nel.org>,
Linus Torvalds <torvalds@...ux-foundation.org>,
Jens Axboe <axboe@...nel.dk>,
Andrew Morton <akpm@...ux-foundation.org>,
werner <w.landgraf@...ru>, "H. Peter Anvin" <hpa@...or.com>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [block IO crash] Re: 2.6.39-rc5-git2 boot crashs
* Christoph Lameter <cl@...ux.com> wrote:
> On Wed, 4 May 2011, Tejun Heo wrote:
>
> > The cmpxchg_double optimization made the fast path go quite faster
> > when CPU supports it but it may as well slow things down considerably
> > if CPU doesn't, due to extra irq on/off's. Anyways, here's hoping
> > that the slow down is acceptable compared to the base code without
> > cmpxchg_double and the ugliness can be removed.
>
> I think we are all in agreement. First path to fix the percpu macros:
>
>
> Subject: percpu: Fix irqsafe_cpu_cmpxchg_double
>
> The function in the macro was not updated when the function was given a bool return value.
>
> Signed-off-by: Christoph Lameter <cl@...ux.com>
Note, the final commit needs to have a proper Reported-by and explanation about
how this was triggered, to fairly credit all the hard work done by Werner ...
Thanks,
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists