linux-kernel - Re: [PATCH] m68k/atari: Do not use "/" in interrupt names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BANLkTind9TLfuyVmRnRZJotFPgOebwf-dw@mail.gmail.com>
Date:	Wed, 4 May 2011 19:45:37 +0200
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Andreas Schwab <schwab@...ux-m68k.org>
Cc:	"Linux/m68k" <linux-m68k@...ts.linux-m68k.org>,
	Linux Kernel Development <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] m68k/atari: Do not use "/" in interrupt names

On Wed, May 4, 2011 at 17:00, Andreas Schwab <schwab@...ux-m68k.org> wrote:
> Geert Uytterhoeven <geert@...ux-m68k.org> writes:
>> diff --git a/arch/m68k/atari/atakeyb.c b/arch/m68k/atari/atakeyb.c
>> index e1ada31..779efdc 100644
>> --- a/arch/m68k/atari/atakeyb.c
>> +++ b/arch/m68k/atari/atakeyb.c
>> @@ -572,7 +572,7 @@ int atari_keyb_init(void)
>>       kb_state.len = 0;
>>
>>       error = request_irq(IRQ_MFP_ACIA, atari_keyboard_interrupt,
>> -                         IRQ_TYPE_SLOW, "keyboard/mouse/MIDI",
>> +                         IRQ_TYPE_SLOW, "keyboard:mouse:MIDI",
>
> The name is not a path, but an enumeration, so the slash should probably
> be changed to a comma instead.

I thought about that, but comma (albeit followed by a space) is also used to
separate multiple interrupt handlers for shared interrupts.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/