linux-kernel - [PATCH] Allocate memory cgroup structures in local nodes v2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1304540783-8247-1-git-send-email-andi@firstfloor.org>
Date:	Wed,  4 May 2011 13:26:23 -0700
From:	Andi Kleen <andi@...stfloor.org>
To:	akpm@...ux-foundation.org
Cc:	linux-mm@...ck.org, linux-kernel@...r.kernel.org,
	Andi Kleen <ak@...ux.intel.com>, rientjes@...gle.com,
	Michal Hocko <mhocko@...e.cz>,
	Dave Hansen <dave@...ux.vnet.ibm.com>,
	Balbir Singh <balbir@...ibm.com>,
	Johannes Weiner <hannes@...xchg.org>
Subject: [PATCH] Allocate memory cgroup structures in local nodes v2

From: Andi Kleen <ak@...ux.intel.com>

[Andrew: since this is a regression and a very simple fix
could you still consider it for .39? Thanks]

dde79e005a769 added a regression that the memory cgroup data structures
all end up in node 0 because the first attempt at allocating them
would not pass in a node hint. Since the initialization runs on CPU #0
it would all end up node 0. This is a problem on large memory systems,
where node 0 would lose a lot of memory.

Change the alloc_pages_exact to alloc_pages_exact_node. This will
still fall back to other nodes if not enough memory is available.

[RED-PEN: right now it would fall back first before trying
vmalloc_node. Probably not the best strategy ... But I left it like
that for now.]

v2: Fix argument order. Thanks David Rientjes.
Reported-by: Doug Nelson
Cc: rientjes@...gle.com
CC: Michal Hocko <mhocko@...e.cz>
Cc: Dave Hansen <dave@...ux.vnet.ibm.com>
Cc: Balbir Singh <balbir@...ibm.com>
Cc: Johannes Weiner <hannes@...xchg.org>
Signed-off-by: Andi Kleen <ak@...ux.intel.com>
---
 mm/page_cgroup.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/mm/page_cgroup.c b/mm/page_cgroup.c
index 9905501..a362215 100644
--- a/mm/page_cgroup.c
+++ b/mm/page_cgroup.c
@@ -134,7 +134,7 @@ static void *__init_refok alloc_page_cgroup(size_t size, int nid)
 {
 	void *addr = NULL;

-	addr = alloc_pages_exact(size, GFP_KERNEL | __GFP_NOWARN);
+	addr = alloc_pages_exact_node(nid, GFP_KERNEL | __GFP_NOWARN, size);
 	if (addr)
 		return addr;

-- 
1.7.4.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/