| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <BANLkTimMifZiN-3Gcg2ry_ry-OL0vT8NqA@mail.gmail.com> Date: Wed, 4 May 2011 12:33:33 +0800 From: Axel Lin <axel.lin@...il.com> To: Mark Brown <broonie@...nsource.wolfsonmicro.com> Cc: linux-kernel@...r.kernel.org, Yong Shen <yong.shen@...aro.org>, Liam Girdwood <lrg@...mlogic.co.uk> Subject: Re: [PATCH 1/2] regulator: Put mutex lock down to mc13783_powermisc_rmw function Hi Mark, 2011/5/4 Mark Brown <broonie@...nsource.wolfsonmicro.com>: > On Wed, May 04, 2011 at 12:40:30AM +0800, Axel Lin wrote: >> mc13783_powermisc_rmw function is doing read/modify/write bitmask operations, >> thus add the lock to protect it. >> Then we can remove the lock/unlock from the caller. > > This should be squashed in with the MFD patch I think otherwise we'll > get bisection points with either no lock or double locking (which upsets > lockdep IIRC). The change itself looks good, though, and similarly for > patch 2 > I think these 2 patches are independent from the MFD patch. The MFD patch modified the mc13xxx_reg_rmw which is not called by mc13783_powermisc_rmw and mc13783_powermisc_rmw functions. I double checked the usage of mc13783_powermisc_rmw and mc13783_powermisc_rmw, I think these 2 patches can be applied either with or without the MFD patch. Regards, Axel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists