linux-kernel - Re: [PATCH] alpha: Add DMA_ERROR_CODE defn to avert compiler error in drm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 4 May 2011 17:59:29 -0400
From:	Matt Turner <mattst88@...il.com>
To:	Michael Cree <mcree@...on.net.nz>
Cc:	linux-kernel@...r.kernel.org, linux-alpha@...r.kernel.org,
	Richard Henderson <rth@...ddle.net>,
	Ivan Kokshaysky <ink@...assic.park.msu.ru>
Subject: Re: [PATCH] alpha: Add DMA_ERROR_CODE defn to avert compiler error in drm

On Wed, May 4, 2011 at 4:13 AM, Michael Cree <mcree@...on.net.nz> wrote:
> The radeon drm code now relies on DMA_ERROR_CODE.  This defines
> it in alpha dma-mapping header to at least enable me to compile
> radeon drm/kms into kernel.
>
> Signed-off-by: Michael Cree <mcree@...on.net.nz>
> ---
>  arch/alpha/include/asm/dma-mapping.h |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/arch/alpha/include/asm/dma-mapping.h b/arch/alpha/include/asm/dma-mapping.h
> index 4567aca..644d9c3 100644
> --- a/arch/alpha/include/asm/dma-mapping.h
> +++ b/arch/alpha/include/asm/dma-mapping.h
> @@ -3,6 +3,8 @@
>
>  #include <linux/dma-attrs.h>
>
> +#define DMA_ERROR_CODE 0
> +
>  extern struct dma_map_ops *dma_ops;
>
>  static inline struct dma_map_ops *get_dma_ops(struct device *dev)
> --
> 1.7.4.3
>
>

Other architectures define this differently.

arch/ia64/include/asm/dma-mapping.h:#define DMA_ERROR_CODE 0
arch/microblaze/include/asm/dma-mapping.h:#define DMA_ERROR_CODE
         (~(dma_addr_t)0x0)
arch/powerpc/include/asm/dma-mapping.h:#define DMA_ERROR_CODE
 (~(dma_addr_t)0x0)
arch/sparc/include/asm/dma-mapping.h:#define DMA_ERROR_CODE
(~(dma_addr_t)0x0)
arch/x86/include/asm/dma-mapping.h:#define DMA_ERROR_CODE       0

Any idea what the reason is?

Matt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/