linux-kernel - Re: [PATCH] hung_task_timeout: configurable default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 4 May 2011 15:05:57 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Jeff Mahoney <jeffm@...e.com>
Cc:	Ingo Molnar <mingo@...e.hu>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Mandeep Singh Baines <msb@...gle.com>
Subject: Re: [PATCH] hung_task_timeout: configurable default

On Wed, 27 Apr 2011 14:27:24 -0400
Jeff Mahoney <jeffm@...e.com> wrote:

>  This patch allows the default value for sysctl_hung_task_timeout_secs
>  to be set at build time. The feature carries virtually no overhead,
>  so it makes sense to keep it enabled. On heavily loaded systems, though,
>  it can end up triggering stack traces when there is no bug other than
>  the system being underprovisioned. We use this patch to keep the hung task
>  facility available but disabled at boot-time.
> 
>  The default of 120 seconds is preserved. As a note, commit e162b39a may
>  have accidentally reverted commit fb822db4, which raised the default from
>  120 seconds to 480 seconds.

The changelog forgot to tell us why the patch's author considers the
patch to be needed.  This happens quite a lot.

> @@ -33,7 +33,8 @@ unsigned long __read_mostly sysctl_hung_
>  /*
>   * Zero means infinite timeout - no checking done:
>   */
> -unsigned long __read_mostly sysctl_hung_task_timeout_secs = 120;
> +unsigned long __read_mostly sysctl_hung_task_timeout_secs =
> +					CONFIG_DEFAULT_HUNG_TASK_TIMEOUT;
>  

For the life of me I can't understand why you distro guys need to keep
patching the kernel when you could just add a line to your initscripts.

I'm suspecting that lameness is involved.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/