[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 5 May 2011 22:42:09 +0200 (CEST)
From: Jesper Juhl <jj@...osbits.net>
To: J Freyensee <james_p_freyensee@...ux.intel.com>
cc: gregkh@...e.de, linux-kernel@...r.kernel.org,
suhail.ahmed@...el.com, christophe.guerard@...el.com
Subject: Re: [PATCH 3/4] Intel PTI implementaiton of MIPI 1149.7.
On Thu, 5 May 2011, J Freyensee wrote:
> On Sun, 2011-04-24 at 02:55 +0200, Jesper Juhl wrote:
...
> >
> > kbuff is a local variable. What's the point in assigning NULL to it just
> > before you return? Just get rid of that silly assignment.
>
> I err on the side of paranoia and default to attempting to use good
> programming practices and rather receiving comments like this, than the
> alternative where I should have assigned something to NULL/0 and I
> introduce a security flaw in the driver/kernel.
>
That is all well and good, but assigning to a local variable just before
it goes out of scope is utterly pointless. Nothing can access the variable
afterwards, so it's value is completely irrelevant at that point.
--
Jesper Juhl <jj@...osbits.net> http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists