lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <alpine.LNX.2.00.1105061144200.28291@pobox.suse.cz>
Date:	Fri, 6 May 2011 11:44:32 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Linus Walleij <linus.walleij@...aro.org>
Cc:	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	Joe Perches <joe@...ches.com>
Subject: Re: linux-next: manual merge of the trivial tree with the ux500-core
 tree

On Fri, 6 May 2011, Linus Walleij wrote:

> 2011/5/5 Jiri Kosina <jkosina@...e.cz>:
> > On Fri, 29 Apr 2011, Linus Walleij wrote:
> >>
> >> I rewrote the driver completely so likely it will rather be dropped, but
> >> please check! I'll be happy to carry any patches.
> >
> > Seems to me that all the calls to request_mem_region() and
> > release_mem_region() still need the resource_size() fixup even in the new
> > driver.
> 
> OK I went in and tweaked the patch like this:
> 
> 	if (request_mem_region(gpio->memres->start,
> 			       resource_size(gpio->memres),
> 			       "GPIO Controller")
> 	    == NULL) {
> 		dev_err(gpio->dev, "could not reserve GPIO memory region\n");
> 		err = -ENODEV;
> 		goto err_no_ioregion;
> 	}
> (...)
> err_no_ioremap:
> 	release_mem_region(gpio->memres->start, resource_size(gpio->memres));
> (...)
> 	release_mem_region(gpio->memres->start,
> 			   resource_size(gpio->memres));
> 
> It'll appear in the next tree tomorrow or so. OK?

Thanks. I have dropped Joe's patch from my queue now.

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ