linux-kernel - Re: [RFC 1/2] misc: add Atheros ar1520 GPS support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 6 May 2011 23:26:38 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	"Luis R. Rodriguez" <lrodriguez@...eros.com>
Cc:	<akpm@...ux-foundation.org>, <mingo@...hat.com>,
	<tglx@...utronix.de>, <hpa@...or.com>, <x86@...nel.org>,
	<linux-kernel@...r.kernel.org>, <linux-wireless@...r.kernel.org>,
	<allen.kao@...eros.com>, <roman.gezikov@...eros.com>,
	<joonas.viskari@...eros.com>
Subject: Re: [RFC 1/2] misc: add Atheros ar1520 GPS support

Last time this driver came up the answer was that the userspace was
proprietary and this was in fact part of a mixed user/kernel driver which
seemed to raise all sorts of interesting questions.

This was NAKked before for that reason so why the resubmit. Kernel policy
is clear enough ?

> + * You need a userspace application to cooperate with this driver. It and
> + * more information about this driver can be obtained here:
> + *
> + * http://wireless.kernel.org/en/users/Drivers/ar5120

Which says:

Userspace application

This driver requires a userspace application which will interact with the
driver via ioctl. More information on this to be posted later. 

So NAK

Let's see an open userspace and then this driver can be submitted

+		time =
  wait_event_interruptible_timeout(ar1520_data->wait_irq,
+
  ar1520_data->irq_rx, +
  msecs_to_jiffies(3142));

Why 3142 ?

Come to think of it why not fixes the races while you are it.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/