linux-kernel - Re: PATCH] mm: Use alloc_bootmem_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 7 May 2011 10:22:57 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Yinghai Lu <yinghai@...nel.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	"H. Peter Anvin" <hpa@...ux.intel.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Stefan Hellermann <stefan@...2masters.de>,
	linux-kernel@...r.kernel.org
Subject: Re: PATCH] mm: Use alloc_bootmem_node_nopanic on really needed path


* Yinghai Lu <yinghai@...nel.org> wrote:

> On 05/06/2011 03:39 PM, Andrew Morton wrote:
> > On Fri, 06 May 2011 15:29:41 -0700
> > Yinghai Lu <yinghai@...nel.org> wrote:
> > 
> >> Stefan found nobootmem does not work on his system that only have 8M ram.
> > 
> > What does "does not work" mean?  From the patch, it appears that the
> > machine paniced?
> 
> yes, early panic.

Why the heck did you not share this information in the original changelog 
itself? Do you think maintainers enjoy having to waste time asking you again 
and again to clarify your changelogs?

Changelogs need specificity. "does not work" is 10 times worse than "we saw an 
early crash" or "the system booted up with only 10% of the physical RAM 
visible". There are many degrees of "does not work".

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/