linux-kernel - Re: [PATCH] alpha: Add DMA_ERROR_CODE defn to avert compiler error in drm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110507090257L.fujita.tomonori@lab.ntt.co.jp>
Date:	Sat, 7 May 2011 09:05:50 +0900
From:	FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>
To:	konrad.wilk@...cle.com
Cc:	fujita.tomonori@....ntt.co.jp, mcree@...on.net.nz,
	linux-kernel@...r.kernel.org, linux-alpha@...r.kernel.org,
	mattst88@...il.com, rth@...ddle.net, ink@...assic.park.msu.ru
Subject: Re: [PATCH] alpha: Add DMA_ERROR_CODE defn to avert compiler error
 in drm

On Fri, 6 May 2011 09:49:25 -0400
Konrad Rzeszutek Wilk <konrad.wilk@...cle.com> wrote:

> On Fri, May 06, 2011 at 09:30:03PM +0900, FUJITA Tomonori wrote:
> > On Wed,  4 May 2011 20:13:37 +1200
> > Michael Cree <mcree@...on.net.nz> wrote:
> > 
> > > The radeon drm code now relies on DMA_ERROR_CODE.  This defines
> > > it in alpha dma-mapping header to at least enable me to compile
> > > radeon drm/kms into kernel.
> > > 
> > > Signed-off-by: Michael Cree <mcree@...on.net.nz>
> > > ---
> > >  arch/alpha/include/asm/dma-mapping.h |    2 ++
> > >  1 files changed, 2 insertions(+), 0 deletions(-)
> > 
> > This isn't correct. The drivers should not use DMA_ERROR_CODE directly
> > (some architecture specific drivers use it though). Fix rademon
> > drm/kms instead.
> 
> What would be a proper value for non-existent bus addresses? As in the value
> had not been set? 0?

Zero is a valid DMA address for some devices.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/