| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <4DC4A0B8.7060801@fusionio.com> Date: Fri, 6 May 2011 19:30:32 -0600 From: Jens Axboe <jaxboe@...ionio.com> To: Lukas Czerner <lczerner@...hat.com> CC: "linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Jeff Moyer <jmoyer@...hat.com> Subject: Re: [PATCH] blkdev: Do not return -EOPNOTSUPP if discard is supported On 2011-05-05 09:12, Lukas Czerner wrote: > Currently we return -EOPNOTSUPP in blkdev_issue_discard() if any of the > bio fails due to underlying device not supporting discard request. > However, if the device is for example dm device composed of devices > which some of them support discard and some of them does not, it is ok > for some bios to fail with EOPNOTSUPP, but it does not mean that discard > is not supported at all. > > This commit removes the check for bios failed with EOPNOTSUPP and change > blkdev_issue_discard() to return operation not supported if and only if > the device does not actually supports it, not just part of the device as > some bios might indicate. > > This change also fixes problem with BLKDISCARD ioctl() which now works > correctly on such dm devices. Applied, thanks. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists