linux-kernel - checkpatch "unclean" patches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <201105080955.27160.emil.langrock@gmx.de>
Date:	Sun, 8 May 2011 09:55:26 +0200
From:	Emil Langrock <emil.langrock@....de>
To:	linux-kernel@...r.kernel.org
Cc:	Andy Whitcroft <apw@...onical.com>
Subject: checkpatch "unclean" patches

Hi,

I wanted to send some patches, but checkpatch always tells me that they arent
clean and that I should fix them... but I am sure that the checkpatch.pl is
wrong.

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
ERROR: need consistent spacing around '*' (ctx:WxV)
#70: FILE: abc.h:70:
+	struct xyz __rcu *bar;
 	                 ^

CHECK: spinlock_t definition without comment
#92: FILE: abc.h:92:
+	spinlock_t foo; /* protects: bar, foobar, barfoo, kaazaa, flupflup, fafafa,

total: 1 errors, 0 warnings, 1 checks, 1337 lines checked
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

I am quite sure that the spacing should not be "struct xyz __rcu * bar" and
that the thing behind "spinlock_t foo;" is a comment.

Should I fix my patches or should checkpatch.pl be fixed?
-- 
Emil Langrock
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/