linux-kernel - Re: [PATCH] mm: memory: remove unreachable code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4DC70B45.3020503@redhat.com>
Date:	Sun, 08 May 2011 17:29:41 -0400
From:	Rik van Riel <riel@...hat.com>
To:	Maxin B John <maxin.john@...il.com>
CC:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	walken@...gle.com, aarcange@...hat.com, hughd@...gle.com,
	linux-mm@...ck.org
Subject: Re: [PATCH] mm: memory: remove unreachable code

On 05/08/2011 05:18 PM, Maxin B John wrote:
> Remove the unreachable code found in mm/memory.c
>
> Signed-off-by: Maxin B. John<maxin.john@...il.com>
> ---
> diff --git a/mm/memory.c b/mm/memory.c
> index 27f4253..d3b30af 100644
> --- a/mm/memory.c
> +++ b/mm/memory.c
> @@ -3695,7 +3695,6 @@ static int __access_remote_vm(struct task_struct *tsk, struct mm_struct *mm,
>   			if (ret<= 0)
>   #endif
>   				break;
> -			bytes = ret;
>   		} else {
>   			bytes = len;
>   			offset = addr&  (PAGE_SIZE-1);

Is it really impossible for vma->vm_ops->access to return a
positive value?

-- 
All rights reversed
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/