linux-kernel - Re: [PATCH][WAS:bcmai,axi] bcma: add Broadcom specific AMBA bus driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 8 May 2011 10:43:16 +0200
From:	"Arend van Spriel" <arend@...adcom.com>
To:	Rafał Miłecki <zajec5@...il.com>
cc:	"George Kashperko" <george@...u.edu.ua>,
	"Arnd Bergmann" <arnd@...db.de>,
	"linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
	"John W. Linville" <linville@...driver.com>,
	"b43-dev@...ts.infradead.org" <b43-dev@...ts.infradead.org>,
	"Greg KH" <greg@...ah.com>,
	Michael Büsch <mb@...sch.de>,
	"Larry Finger" <Larry.Finger@...inger.net>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"Russell King" <rmk@....linux.org.uk>,
	"Andy Botting" <andy@...ybotting.com>,
	linuxdriverproject <devel@...uxdriverproject.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH][WAS:bcmai,axi] bcma: add Broadcom specific AMBA bus
 driver

On 05/07/2011 08:48 PM, Rafał Miłecki wrote:
> 2011/5/7 George Kashperko<george@...u.edu.ua>:
>> I guess core id 0x800 by 0x04BF vendor and 0x800 by 0x043B vendor will
>> both be reported as ChipCommon which most likely is wrong for second
>> one. Btw, ChipCommon is 0x500 for 4706 and there will be more new core
>> codes for new Broadcom devices. Don't think its right to build core
>> names database into kernel while there will be at most few of them used
>> on particular end system.
> This is constructive, I'll fix this, thanks.

Hi Rafał,

Late response, but I tried to tell what George clarified by the example 
above so you need nested switch.

I tend to agree with George that having this id to name conversion in 
the bus driver may be nice for debugging, but apart from memory usage it 
also gives you additional maintenance work. Leave it up to you.

Gr. AvS

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/