linux-kernel - Re: [PATCH v3 02/12] mmc: mmc_test: add debugfs file to list all tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BANLkTindMsH4ozajW3E3ifBnrsS=gpOaOQ@mail.gmail.com>
Date:	Sun, 8 May 2011 15:12:46 +0200
From:	Per Forlin <per.forlin@...aro.org>
To:	Andy Shevchenko <andy.shevchenko@...il.com>
Cc:	linux-mmc@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org, linaro-dev@...ts.linaro.org,
	Chris Ball <cjb@...top.org>
Subject: Re: [PATCH v3 02/12] mmc: mmc_test: add debugfs file to list all tests

On 8 May 2011 00:18, Andy Shevchenko <andy.shevchenko@...il.com> wrote:
> On Sat, May 7, 2011 at 10:14 PM, Per Forlin <per.forlin@...aro.org> wrote:
>> Add a debugfs file "testlist" to print all available tests
>>
>> Signed-off-by: Per Forlin <per.forlin@...aro.org>
>> ---
>>  drivers/mmc/card/mmc_test.c |   30 ++++++++++++++++++++++++++++++
>>  1 files changed, 30 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/mmc/card/mmc_test.c b/drivers/mmc/card/mmc_test.c
>> index abc1a63..c1c3c5a 100644
>> --- a/drivers/mmc/card/mmc_test.c
>> +++ b/drivers/mmc/card/mmc_test.c
>
>
>> @@ -2476,6 +2502,10 @@ static int mmc_test_register_file_test(struct mmc_card *card)
>>                file = debugfs_create_file("test", S_IWUSR | S_IRUGO,
>>                        card->debugfs_root, card, &mmc_test_fops_test);
>>
>> +       if (card->debugfs_root)
>> +               file = debugfs_create_file("testlist", S_IRUGO,
>> +                       card->debugfs_root, card, &mmc_test_fops_testlist);
>> +
>>        if (IS_ERR_OR_NULL(file)) {
>>                dev_err(&card->dev,
>>                        "Can't create file. Perhaps debugfs is disabled.\n");
> I think you also need to use similar error path for both files: test
> and testlist.
Thanks, I'll fix that and add this check for both.

>
>
> --
> With Best Regards,
> Andy Shevchenko
>
Regards,
Per
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/