linux-kernel - Re: [PATCH] SOC: UDA134x: Remove POWER_OFF_ON

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1304863821.3246.4.camel@odin>
Date:	Sun, 08 May 2011 15:10:21 +0100
From:	Liam Girdwood <lrg@...mlogic.co.uk>
To:	Marek Belisko <marek.belisko@...n-nandra.com>
Cc:	tiwai@...e.de, perex@...ex.cz, linux-kernel@...r.kernel.org,
	alsa-devel@...a-project.org, broonie@...nsource.wolfsonmicro.com
Subject: Re: [PATCH] SOC: UDA134x: Remove POWER_OFF_ON_STANDBY define.

On Tue, 2011-05-03 at 14:46 +0200, Marek Belisko wrote:
> Define POWER_OFF_ON_STANDBY cause trobles when trying to get some
> sound from codec because code for bias setup was not compiled
> (define wasn't defined). This define was removed in commit:
> cc3202f5 but again introduced by commit: f0fba2ad1 which then
> completely break codec functionality so remove it again.
> 
> Signed-off-by: Marek Belisko <marek.belisko@...n-nandra.com>
> ---
>  sound/soc/codecs/uda134x.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/soc/codecs/uda134x.c b/sound/soc/codecs/uda134x.c
> index 48ffd40..a7b8f30 100644
> --- a/sound/soc/codecs/uda134x.c
> +++ b/sound/soc/codecs/uda134x.c
> @@ -601,9 +601,7 @@ static struct snd_soc_codec_driver soc_codec_dev_uda134x = {
>  	.reg_cache_step = 1,
>  	.read = uda134x_read_reg_cache,
>  	.write = uda134x_write,
> -#ifdef POWER_OFF_ON_STANDBY
>  	.set_bias_level = uda134x_set_bias_level,
> -#endif
>  };
>  
>  static int __devinit uda134x_codec_probe(struct platform_device *pdev)

Acked-by: Liam Girdwood <lrg@...com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/