linux-kernel - Re: [PATCH] usb: fix warning in usbtest module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1105081033140.30441-100000@netrider.rowland.org>
Date:	Sun, 8 May 2011 10:37:53 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Greg Dietsche <gregory.dietsche@....edu>
cc:	gregkh@...e.de, <mfuzzey@...il.com>, <tom.leiming@...il.com>,
	<ak@...ux.intel.com>, <linux-usb@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] usb: fix warning in usbtest module

On Sat, 7 May 2011, Greg Dietsche wrote:

> On amd64 unsigned is not as wide as pointer and this causes
> a compiler warning. Switching to uintptr_t fixes the problem
> in an arch independent manner.

People tend to prefer to see non-typedef'ed type names, whenever 
possible.  In this case, it would be enough to change the type to 
unsigned long.

Lots of code throughout the kernel stores pointer values in unsigned 
long variables.  I've never heard any recommendation for using 
uintptr_t instead.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/