linux-kernel - RE: [PATCH v5] staging: Add ST-Ericsson CG2900 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AFCDDB4A3EA003429EEF1E7B211FDBBA33959B23C3@EXDCVYMBSTM005.EQ1STM.local>
Date:	Mon, 9 May 2011 14:07:02 +0200
From:	Par-Gunnar HJALMDAHL <par-gunnar.p.hjalmdahl@...ricsson.com>
To:	Greg KH <greg@...ah.com>
Cc:	Greg Kroah-Hartman <gregkh@...e.de>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	Linus Walleij <linus.walleij@...aro.org>,
	Mathieu Poirier <mathieu.poirier@...aro.org>,
	Linus WALLEIJ <linus.walleij@...ricsson.com>,
	Arnd Bergmann <arnd@...db.de>,
	Vitaly Wool <vitalywool@...il.com>,
	Marcel Holtmann <marcel@...tmann.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Lukasz Rymanowski <Lukasz.Rymanowski@...to.com>,
	"linux-bluetooth@...r.kernel.org" <linux-bluetooth@...r.kernel.org>,
	Pavan Savoy <pavan_savoy@...y.com>,
	Lee Jones <lee.jones@...aro.org>,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Par-Gunnar Hjalmdahl <pghatwork@...il.com>
Subject: RE: [PATCH v5] staging: Add ST-Ericsson CG2900 driver

> -----Original Message-----
> From: Greg KH [mailto:greg@...ah.com]
> Sent: den 3 maj 2011 19:50
> 
> What changed in this version?  It still doesn't apply properly to the
> linux-next tree, which shows me that I don't think anything really
> changed here.
> 

What I changed from v4 was in particular to adapt to changes to mfd.
The mfd device data name had been changed from platform_data (plus length)
to mfd_data. This was modified cg2900_chip.c and stlc2690.c.
In connection to this I also modified so we used the function mfd_get_data
to retrieve the platform data.
There had also been one parameter removed in the call to tty->ops->tiocmget
so I had to modify the call in hci_ldisc as well.

> Can you rediff it so it properly applies (i.e. why are you adding your
> driver to the middle of drivers/staging/Makefile and not at the end
> which is where it properly belongs?) and resend it?

I will do another try, but I honestly do not know why it doesn't apply.
The reason for the placement in the makefile I do not remember at the
moment, probably just a simple mistake from my part. I agree that I
should have placed it last in the file.

Thanks,
/P-G
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/