linux-kernel - Re: [PATCHv2 -next] MFD: MFD module of DA9052 PMIC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110509124022.GD3225@opensource.wolfsonmicro.com>
Date:	Mon, 9 May 2011 14:40:23 +0200
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Ashish Jangam <Ashish.Jangam@...tcummins.com>
Cc:	"sameo@...nedhand.com" <sameo@...nedhand.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Dajun Chen <Dajun.Chen@...semi.com>
Subject: Re: [PATCHv2 -next] MFD: MFD module of DA9052 PMIC driver

On Mon, May 09, 2011 at 04:03:41PM +0530, Ashish Jangam wrote:

> > > +static void da9052_irq_sync_unlock(struct irq_data *data)
> > > +{
> > > +       struct da9052 *da9052 = irq_data_get_irq_chip_data(data);
> > > +       struct da9052_irq_data *irq_data = irq_to_da9052_irq(da9052,
> > > +                                               data->irq);
> > > +
> > > +       da9052_mask_events(da9052, irq_data->event);
> > > +       mutex_unlock(&da9052->irq_lock);

> > What happens if an event was enabled while the bus was locked?

Fix your MUA to word wrap within paragraphs.

> Event stays in the hardware till it's not explicitly cleared. Hence
> there won't be any event loss.

You're missing the point here.  You've not understood what the purpose
of the lock and unlock are - they should be syncing back changes to the
mask state that were made while the lock was held.  This is doing
something totally different.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/