linux-kernel - Re: [PATCH] pci, dmar: flush IOTLB before exit domain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1304952530.30435.16.camel@i7.infradead.org>
Date:	Mon, 09 May 2011 15:48:49 +0100
From:	David Woodhouse <dwmw2@...radead.org>
To:	Yinghai Lu <yinghai.lu@...cle.com>, Kalle Valo <kvalo@...rom.com>
Cc:	Jesse Barnes <jbarnes@...tuousgeek.org>,
	"iommu@...ts.linux-foundation.org" <iommu@...ts.linux-foundation.org>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] pci, dmar: flush IOTLB before exit domain

On Thu, 2011-05-05 at 18:13 -0700, Yinghai Lu wrote:
> @@ -3252,6 +3252,9 @@ static int device_notifier(struct notifi
>                 return 0;
>  
>         if (action == BUS_NOTIFY_UNBOUND_DRIVER && !iommu_pass_through) {
> +               /* before we remove dev with domain, flush IOTLB */
> +               flush_unmaps();
> +
>                 domain_remove_one_dev_info(domain, pdev);
>  
>                 if (!(domain->flags & DOMAIN_FLAG_VIRTUAL_MACHINE) && 

That calls flush_unmaps() without the async_umap_flush_lock held,
doesn't it? A few days ago I asked someone else to test this candidate
patch for a similar issue:

http://david.woodhou.se/flush-unmaps-on-unbind.patch

-- 
David Woodhouse                            Open Source Technology Centre
David.Woodhouse@...el.com                              Intel Corporation

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/