linux-kernel - Re: [PATCH]mm/migrate.c: clean up comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20110509141347.51ccc087.akpm@linux-foundation.org>
Date:	Mon, 9 May 2011 14:13:47 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	"Figo.zhang" <figo1802@...il.com>
Cc:	lkml <linux-kernel@...r.kernel.org>,
	"linux-mm@...ck.org" <linux-mm@...ck.org>,
	Mel Gorman <mel@....ul.ie>
Subject: Re: [PATCH]mm/migrate.c: clean up comment

On Sat, 07 May 2011 00:03:11 +0800
"Figo.zhang" <figo1802@...il.com> wrote:

> 
> clean up comment. prepare cgroup return 0 or -ENOMEN, others return -EAGAIN.
> avoid conflict meanings.
> 
> Signed-off-by: Figo.zhang <figo1802@...il.com>
> ---
> mm/migrate.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/mm/migrate.c b/mm/migrate.c
> index 34132f8..d65b351 100644
> --- a/mm/migrate.c
> +++ b/mm/migrate.c
> @@ -647,7 +647,6 @@ static int unmap_and_move(new_page_t get_new_page, unsigned long private,
>  		if (unlikely(split_huge_page(page)))
>  			goto move_newpage;
>  
> -	/* prepare cgroup just returns 0 or -ENOMEM */
>  	rc = -EAGAIN;
>  
>  	if (!trylock_page(page)) {
> @@ -687,7 +686,7 @@ static int unmap_and_move(new_page_t get_new_page, unsigned long private,
>  		goto unlock;
>  	}
>  
> -	/* charge against new page */
> +	/* charge against new page, return 0 or -ENOMEM */
>  	charge = mem_cgroup_prepare_migration(page, newpage, &mem, GFP_KERNEL);
>  	if (charge == -ENOMEM) {
>  		rc = -ENOMEM;

Well it's still pretty confusing - the function can also return -EAGAIN
and -EBUSY, at least.

It would be better to remove this random sprinkle of commentlets and to
properly document unmap_and_move()'s interface in the usual fashion, in
its leading comment block.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/