linux-kernel - RE: [PATCH V2 2/5] pch_dma: modify for checkpatch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <40C404F4AEB54380A9E9235D0C420C4B@hacdom.okisemi.com>
Date:	Mon, 9 May 2011 14:27:47 +0900
From:	"Tomoya MORINAGA" <tomoya-linux@....okisemi.com>
To:	"'Joe Perches'" <joe@...ches.com>
Cc:	"'Dan Williams'" <dan.j.williams@...el.com>,
	"'Vinod Koul'" <vinod.koul@...el.com>,
	<linux-kernel@...r.kernel.org>, <qi.wang@...el.com>,
	<yong.y.wang@...el.com>, <joel.clark@...el.com>,
	<kok.howg.ewe@...el.com>, <toshiharu-linux@....okisemi.com>
Subject: RE: [PATCH V2 2/5] pch_dma: modify for checkpatch

Hi Joe,

On Monday, May 09, 2011 1:02 PM, Joe Perches wrote:
> > @@ -138,7 +138,8 @@ struct pch_dma {
> > -static inline struct pch_dma_desc *to_pd_desc(struct 
> > dma_async_tx_descriptor *txd)
> > +static inline struct pch_dma_desc *to_pd_desc(
> > +					struct 
> dma_async_tx_descriptor *txd)
> 
> I think these are better either not changed at all or to 
> either of the styles below:
> 
> static inline struct pch_dma_desc *
> to_pd_desc(struct dma_async_tx_descriptor *txd)
> 
> static inline
> struct pch_dma_desc *to_pd_desc(struct dma_async_tx_descriptor *txd)

 I will use the following.
> static inline
> struct pch_dma_desc *to_pd_desc(struct dma_async_tx_descriptor *txd)

Thanks,
-----------------------------------------
Tomoya MORINAGA
OKI SEMICONDUCTOR CO., LTD.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/