linux-kernel - Re: [PATCH 1/5] PM / Runtime: Support for generic I/O power domains (v3)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BANLkTin49iSYn=r8G=L0S2vnZhtZw6RFpw@mail.gmail.com>
Date:	Tue, 10 May 2011 16:22:00 +0800
From:	Lin Ming <minggr@...il.com>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
Cc:	Linux PM mailing list <linux-pm@...ts.linux-foundation.org>,
	Greg KH <gregkh@...e.de>, LKML <linux-kernel@...r.kernel.org>,
	Kevin Hilman <khilman@...com>,
	Grant Likely <grant.likely@...retlab.ca>,
	Magnus Damm <magnus.damm@...il.com>, linux-sh@...r.kernel.org,
	MyungJoo Ham <myungjoo.ham@...il.com>,
	Guennadi Liakhovetski <g.liakhovetski@....de>
Subject: Re: [PATCH 1/5] PM / Runtime: Support for generic I/O power domains (v3)

On Mon, May 9, 2011 at 5:22 AM, Rafael J. Wysocki <rjw@...k.pl> wrote:
> From: Rafael J. Wysocki <rjw@...k.pl>

> +
> +/**
> + * __pm_genpd_restore_device - Restore a pre-suspend state of a device.
> + * @dev: Device to restore the state of.
> + * @genpd: Power domain the device belongs to.
> + */
> +static void __pm_genpd_restore_device(struct device *dev,
> +                                     struct generic_power_domain *genpd)
> +{
> +       struct device_driver *drv = dev->driver;
> +
> +       if (genpd->start_device)
> +               genpd->start_device(dev);
> +
> +       if (drv && drv->pm && drv->pm->runtime_resume)
> +               drv->pm->runtime_resume(dev);
> +
> +       if (genpd->stop_device)
> +               genpd->stop_device(dev);
> +}

Why call ->stop_device in restore function?

BTW,
you implemented power domains for ARM / shmobile,
What can we do for other arches?
I wonder how to implement this "power domain" on x86.

Thanks,
Lin Ming
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/