linux-kernel - Re: [PATCH resend] s390: oprofile: fix error checks in oprofile_hwsampler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110510111926.788d7336@mschwide>
Date:	Tue, 10 May 2011 11:19:26 +0200
From:	Martin Schwidefsky <schwidefsky@...ibm.com>
To:	Robert Richter <robert.richter@....com>
Cc:	Nicolas Kaiser <nikai@...ai.net>,
	Heiko Carstens <heiko.carstens@...ibm.com>,
	"linux390@...ibm.com" <linux390@...ibm.com>,
	"oprofile-list@...ts.sf.net" <oprofile-list@...ts.sf.net>,
	"linux-s390@...r.kernel.org" <linux-s390@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH resend] s390: oprofile: fix error checks in
 oprofile_hwsampler_init()

On Tue, 10 May 2011 11:00:54 +0200
Robert Richter <robert.richter@....com> wrote:

> > Ok, the improved patch now looks like this:
> > --
> > Subject: [PATCH] s390: oprofile: fix min/max interval query checks
> > 
> > From: Martin Schwidefsky <schwidefsky@...ibm.com>
> > 
> > oprofile_min_interval and oprofile_max_interval are unsigned, checking
> > for negative values doesn't work. Change hwsampler_query_min_interval
> > and hwsampler_query_max_interval to return an unsigned long and
> > check for a zero value instead.
> > 
> > Reported-by: Nicolas Kaiser <nikai@...ai.net>
> > Signed-off-by: Martin Schwidefsky <schwidefsky@...ibm.com>
> 
> Looks good.
> 
> Acked-by: Robert Richter <robert.richter@....com>
> 
> Martin, can you queue this up?

Yes, I will do that.

-- 
blue skies,
   Martin.

"Reality continues to ruin my life." - Calvin.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/