linux-kernel - Re: [PATCH v9 7/7] usb: Adding SuperSpeed support to dummy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4DC92089.40305@ru.mvista.com>
Date:	Tue, 10 May 2011 15:24:57 +0400
From:	Sergei Shtylyov <sshtylyov@...sta.com>
To:	Tatyana Brokhman <tlinder@...eaurora.org>
CC:	Sebastian Andrzej Siewior <bigeasy@...utronix.de>, greg@...ah.com,
	linux-usb@...r.kernel.org, linux-arm-msm@...r.kernel.org,
	balbi@...com, ablay@...eaurora.org,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v9 7/7] usb: Adding SuperSpeed support to dummy_hcd

Hello.

On 09-05-2011 21:49, Sebastian Andrzej Siewior wrote:

>> +
>> +	retval = usb_add_hcd(hs_hcd, 0, IRQF_DISABLED | IRQF_SHARED);

> Why IRQF_DISABLED | IRQF_SHARED? you don't interrupts at all.

    Moreover, IRQF_DISABLED is a nop now, see <linux/interrupt.h>.

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/