linux-kernel - Re: [PATCHv1 -next] WATCHDOG: Watchdog module of DA9052 device driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20110510111400.GB6865@infomag.iguana.be>
Date:	Tue, 10 May 2011 13:14:00 +0200
From:	Wim Van Sebroeck <wim@...ana.be>
To:	Ashish Jangam <Ashish.Jangam@...tcummins.com>,
	David Dajun Chen <Dajun.Chen@...semi.com>
Cc:	"Linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Linux Watchdog Mailing List <linux-watchdog@...r.kernel.org>
Subject: Re: [PATCHv1 -next] WATCHDOG: Watchdog module of DA9052 device
	driver

Hi Ashish, David,

Driver looks OK at first glance. Will look at it some more later this week.

> +static int __devexit da9052_sm_remove(struct platform_device *dev)
> +{
> +       misc_deregister(&da9052_wdt_miscdev);
> +       strobe_interval = 0;
> +       strobe_mode = 0;
> +       return 0;
> +}

Small remark: here I am missing a kfree(wdt);

Kind regards,
Wim.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/