linux-kernel - Re: [RFC][PATCH] pstore: EFI Support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110510161137.GA14522@kroah.com>
Date:	Tue, 10 May 2011 09:11:37 -0700
From:	Greg KH <greg@...ah.com>
To:	Seiji Aguchi <seiji.aguchi@....com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"x86@...nel.org" <x86@...nel.org>,
	"Luck, Tony" <tony.luck@...el.com>,
	"xiyou.wangcong@...il.com" <xiyou.wangcong@...il.com>,
	"hpa@...or.com" <hpa@...or.com>,
	"mikew@...gle.com" <mikew@...gle.com>,
	"a.p.zijlstra@...llo.nl" <a.p.zijlstra@...llo.nl>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"tj@...nel.org" <tj@...nel.org>,
	"fweisbec@...il.com" <fweisbec@...il.com>,
	"dle-develop@...ts.sourceforge.net" 
	<dle-develop@...ts.sourceforge.net>,
	Satoru Moriya <satoru.moriya@....com>
Subject: Re: [RFC][PATCH] pstore: EFI Support

On Tue, May 10, 2011 at 11:00:44AM -0400, Seiji Aguchi wrote:
> Description of boot paremeters is following.
> 
>  - efi_pstore_enable
>    enable EFI support of pstore.
> 
>  - efi_pstore_len
>    Sets the buffer size of EFI variable space used by pstore.

Please don't add new boot parameters if at all possible.  Distros will
not know to enable them, and users don't know how to either.

Use sane defaults, and provide ways to override them if needed, but
don't rely on them for new functionality if at all possible.

Why would this option ever _not_ be something that should be enabled?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/